Add instrumentation to track the IceCandidatePairType and IceConnectionState

content/renderer/media/rtc_peer_connection_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RTC_PEER_CONNECTION_HANDLER_H_
 #define CONTENT_RENDERER_MEDIA_RTC_PEER_CONNECTION_HANDLER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 186 matching lines @@
       const scoped_refptr<webrtc::MediaStreamInterface>& stream);
   void OnDataChannel(scoped_ptr<RtcDataChannelHandler> handler);
   void OnIceCandidate(const std::string& sdp, const std::string& sdp_mid,
       int sdp_mline_index, int component, int address_family);
 
  private:
   webrtc::SessionDescriptionInterface* CreateNativeSessionDescription(
       const std::string& sdp, const std::string& type,
       webrtc::SdpParseError* error);
 
+  // Report to UMA whether an IceConnectionState has occurred. It only records
+  // the first occurrence of a given state.
+  void ReportICEState(
+      webrtc::PeerConnectionInterface::IceConnectionState new_state);
+
+  // Reset UMA related members to the initial state. This is invoked at the
+  // constructor as well as after Ice Restart.
+  void ResetUMAStats();
+
   // Virtual to allow mocks to override.
   virtual scoped_refptr<base::SingleThreadTaskRunner> signaling_thread() const;
 
   void RunSynchronousClosureOnSignalingThread(const base::Closure& closure,
                                               const char* trace_event_name);
 
   base::ThreadChecker thread_checker_;
 
   // |client_| is a weak pointer, and is valid until stop() has returned.
   blink::WebRTCPeerConnectionHandlerClient* client_;
@@ skipping 22 matching lines @@
   scoped_refptr<Observer> peer_connection_observer_;
 
   // |native_peer_connection_| is the libjingle native PeerConnection object.
   scoped_refptr<webrtc::PeerConnectionInterface> native_peer_connection_;
 
   typedef std::map<webrtc::MediaStreamInterface*,
       content::RemoteMediaStreamImpl*> RemoteStreamMap;
   RemoteStreamMap remote_streams_;
   scoped_refptr<webrtc::UMAObserver> uma_observer_;
   base::TimeTicks ice_connection_checking_start_;
+
+  // Track which ICE Connection state that this PeerConnection has gone through.
+  bool ice_state_seen_[webrtc::PeerConnectionInterface::kIceConnectionMax];

[tommi (sloooow) - chröme, 2015/08/19 19:29:26]

What about initializing here:

bool ice_state_seen_[webrtc::PeerConnectionInterface::kIceConnectionMax] = {};

[guoweis_left_chromium, 2015/08/19 19:37:29]

Done. 

However, what is the best practice here? Should we start to use c+11
initialization even if anything else is not using that?

[tommi (sloooow) - chröme, 2015/08/19 19:46:18]

Hmm... there aren't that many variables that need explicit initialization. Do
you mind moving them to in-class?  Alternatively I can do it after you land this
cl.

+
   base::WeakPtrFactory<RTCPeerConnectionHandler> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RTCPeerConnectionHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_RTC_PEER_CONNECTION_HANDLER_H_