Disable NaCl browser_tests for GN builds.

Disable NaCl browser_tests for GN builds.

BUG=462791
Committed: https://crrev.com/d4285ccfd505314d7aeae814946e6f58758c001c
Cr-Commit-Position: refs/heads/master@{#342490}

[jam, 2015-08-07 19:41:15]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2015-08-07 19:41:24]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-08-07 19:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274213005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274213005/1

[commit-bot: I haz the power, 2015-08-07 19:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 19:41:43]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2015-08-07 19:51:03]

All of these files are in the browser_tests target. Can we move the build
configuration to that one file to avoid setting this define for every file in
the entire build?

[jam, 2015-08-07 20:31:21]

On 2015/08/07 19:51:03, brettw wrote:
> All of these files are in the browser_tests target. Can we move the build
> configuration to that one file to avoid setting this define for every file in
> the entire build?

good point, done.

[brettw, 2015-08-07 21:11:57]

lgtm

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:683: declare_args() {
Can you put this declare_args at the top of the file after the imports? That's
where I normally put it.

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:684: # Switches to using platform functions instead of ICU
on Android.
This comment is, um, wrong.

[jam, 2015-08-07 21:16:35]

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:683: declare_args() {
On 2015/08/07 21:11:57, brettw wrote:
> Can you put this declare_args at the top of the file after the imports? That's
> where I normally put it.

Done.

https://codereview.chromium.org/1274213005/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:684: # Switches to using platform functions instead of ICU
on Android.
On 2015/08/07 21:11:57, brettw wrote:
> This comment is, um, wrong.

Done.

[jam, 2015-08-07 21:17:10]

The CQ bit was checked by jam@chromium.org

[jam, 2015-08-07 21:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1274213005/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2015-08-07 21:17:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274213005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274213005/40001

[commit-bot: I haz the power, 2015-08-07 22:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 22:25:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2015-08-07 22:40:16]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-08-07 22:41:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274213005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274213005/40001

[commit-bot: I haz the power, 2015-08-08 00:34:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-08 00:35:28]

Patchset 3 (id:??) landed as
https://crrev.com/d4285ccfd505314d7aeae814946e6f58758c001c
Cr-Commit-Position: refs/heads/master@{#342490}