Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/test/BUILD.gn

Issue 1274213005: Disable NaCl browser_tests for GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//chrome/chrome_tests.gni") 9 import("//chrome/chrome_tests.gni")
10 import("//chrome/test/base/js2gtest.gni") 10 import("//chrome/test/base/js2gtest.gni")
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
671 "//ppapi:ppapi_tests", 671 "//ppapi:ppapi_tests",
672 "//ppapi:power_saver_test_plugin", 672 "//ppapi:power_saver_test_plugin",
673 "//remoting/webapp:browser_test_resources", 673 "//remoting/webapp:browser_test_resources",
674 "//remoting/webapp:unit_tests", 674 "//remoting/webapp:unit_tests",
675 "//third_party/mesa:osmesa", 675 "//third_party/mesa:osmesa",
676 "//third_party/widevine/cdm:widevine_test_license_server", 676 "//third_party/widevine/cdm:widevine_test_license_server",
677 ] 677 ]
678 678
679 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] 679 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
680 680
681 # TODO(GYP) http://crbug.com/462791
682 defines += [ "DISABLE_NACL_BROWSERTESTS" ]
683 declare_args() {
brettw 2015/08/07 21:11:57 Can you put this declare_args at the top of the fi
jam 2015/08/07 21:16:35 Done.
684 # Switches to using platform functions instead of ICU on Android.
brettw 2015/08/07 21:11:57 This comment is, um, wrong.
jam 2015/08/07 21:16:35 Done.
685 enable_nacl_browsertests = false
686 }
687
681 # TODO(GYP) if (is_win) { 688 # TODO(GYP) if (is_win) {
682 # ['incremental_chrome_dll==1', { 689 # ['incremental_chrome_dll==1', {
683 # 'UseLibraryDependencyInputs': "true", 690 # 'UseLibraryDependencyInputs': "true",
684 # } 691 # }
685 692
686 if (cld_version == 2) { 693 if (cld_version == 2) {
687 # Because the browser_tests use translate, they need CLD data. 694 # Because the browser_tests use translate, they need CLD data.
688 deps += [ "//third_party/cld_2:cld2_platform_impl" ] 695 deps += [ "//third_party/cld_2:cld2_platform_impl" ]
689 } 696 }
690 697
691 if (!enable_one_click_signin) { 698 if (!enable_one_click_signin) {
692 sources -= [ "../browser/ui/sync/one_click_signin_bubble_links_delegate_br owsertest.cc" ] 699 sources -= [ "../browser/ui/sync/one_click_signin_bubble_links_delegate_br owsertest.cc" ]
693 } 700 }
694 if (enable_nacl) { 701 if (!enable_nacl_browsertests) {
702 sources -= [ "../browser/extensions/api/hotword_private/hotword_private_ap itest.cc" ]
703 } else if (enable_nacl) {
695 sources += [ 704 sources += [
696 "../browser/extensions/extension_nacl_browsertest.cc", 705 "../browser/extensions/extension_nacl_browsertest.cc",
697 "../browser/nacl_host/test/gdb_debug_stub_browsertest.cc", 706 "../browser/nacl_host/test/gdb_debug_stub_browsertest.cc",
698 ] 707 ]
699 deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ] 708 deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
700 709
701 if (enable_nacl_untrusted) { 710 if (enable_nacl_untrusted) {
702 sources += [ 711 sources += [
703 "nacl/nacl_browsertest.cc", 712 "nacl/nacl_browsertest.cc",
704 "nacl/nacl_browsertest_uma.cc", 713 "nacl/nacl_browsertest_uma.cc",
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 "../renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc", 958 "../renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc",
950 "../renderer/spellchecker/spellcheck_unittest.cc", 959 "../renderer/spellchecker/spellcheck_unittest.cc",
951 ] 960 ]
952 } 961 }
953 if (is_chromeos) { 962 if (is_chromeos) {
954 sources += [ 963 sources += [
955 "../browser/extensions/api/networking_private/networking_private_apitest .cc", 964 "../browser/extensions/api/networking_private/networking_private_apitest .cc",
956 "../browser/extensions/api/networking_private/networking_private_chromeo s_apitest.cc", 965 "../browser/extensions/api/networking_private/networking_private_chromeo s_apitest.cc",
957 ] 966 ]
958 } 967 }
959 if (!is_android && !is_ios) { 968 if (!is_android && !is_ios && enable_nacl_browsertests) {
960 sources += 969 sources +=
961 [ "../browser/copresence/chrome_whispernet_client_browsertest.cc" ] 970 [ "../browser/copresence/chrome_whispernet_client_browsertest.cc" ]
962 deps += [ "//components/copresence" ] 971 deps += [ "//components/copresence" ]
963 } 972 }
964 if (enable_app_list) { 973 if (enable_app_list) {
965 sources += rebase_path( 974 sources += rebase_path(
966 chrome_tests_gypi_values.chrome_browser_tests_app_list_sources, 975 chrome_tests_gypi_values.chrome_browser_tests_app_list_sources,
967 ".", 976 ".",
968 "//chrome") 977 "//chrome")
969 } 978 }
(...skipping 923 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 "//third_party/mojo/src/mojo/edk/system", 1902 "//third_party/mojo/src/mojo/edk/system",
1894 ] 1903 ]
1895 1904
1896 if (!is_android && use_ash) { 1905 if (!is_android && use_ash) {
1897 sources += rebase_path( 1906 sources += rebase_path(
1898 chrome_tests_unit_gypi_values.chrome_test_support_unit_ash_sources, 1907 chrome_tests_unit_gypi_values.chrome_test_support_unit_ash_sources,
1899 ".", 1908 ".",
1900 "//chrome") 1909 "//chrome")
1901 } 1910 }
1902 } 1911 }
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/test/nacl/nacl_browsertest_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698