Issue 12742009: [telemetry] Fix testConsoleOutputStream failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12742009: [telemetry] Fix testConsoleOutputStream failure (Closed)

Created:
7 years, 9 months ago by nduca

Modified:
7 years, 8 months ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Fix testConsoleOutputStream failure BUG=222657 R=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194723

Patch Set 2 : nits #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dtu

lgtmnits https://codereview.chromium.org/12742009/diff/1/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py File tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py (right): https://codereview.chromium.org/12742009/diff/1/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py#newcode35 tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py:35: expected_l = 'At %s: Hello, world' % prefix ...

7 years, 9 months ago (2013-03-21 05:30:56 UTC) #2

dtu

7 years, 8 months ago (2013-04-17 23:46:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r194723 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12742009: [telemetry] Fix testConsoleOutputStream failure (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Messages