tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py - Issue 12742009: [telemetry] Fix testConsoleOutputStream failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py

Issue 12742009: [telemetry] Fix testConsoleOutputStream failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py

diff --git a/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py b/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py

index 76c611c4da5b34018e135fec956bfb7918274afe..efbe2738b1769483a06fe9662ca8d6295b6474df 100644

--- a/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py

+++ b/tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py

@@ -30,7 +30,8 @@ class TabConsoleTest(tab_test_case.TabTestCase):

lines = [l for l in stream.getvalue().split('\n') if len(l)]

self.assertTrue(len(lines) >= 1)

- for l in lines:

- u_l = 'http://localhost:(\d+)/page_that_logs_to_console.html:9'

- self.assertTrue(re.match('At %s: Hello, world' % u_l, l))

+ for line in lines:

+ prefix = 'http://(.+)/page_that_logs_to_console.html:9'

+ expected_line = 'At %s: Hello, world' % prefix

+ self.assertTrue(re.match(expected_line, line))

« no previous file with comments | « no previous file | no next file » | no next file with comments »