test/webkit/class-syntax-name.js - Issue 1274193004: Let eval scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/webkit/class-syntax-name.js

Issue 1274193004: Let eval scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Changes for code review Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/webkit/class-syntax-name.js

diff --git a/test/webkit/class-syntax-name.js b/test/webkit/class-syntax-name.js

index 09faa3a54aed5fe6d09c08e51506409afea3c0e6..16045651ef35adc5869ec73246e6cf658a4e0cea 100644

--- a/test/webkit/class-syntax-name.js

+++ b/test/webkit/class-syntax-name.js

@@ -111,5 +111,5 @@ runTestShouldBe("class A { constructor() { } }; A = 1; A", "1");

runTestShouldNotThrow("class A {}; var result = A; result");

shouldBe("eval('var Foo = 10'); Foo", "10");

shouldThrow("'use strict'; eval('var Foo = 10'); Foo");

-shouldBe("eval('class Bar { constructor() {} }'); Bar.toString()", "'class Bar { constructor() {} }'");

+shouldBe("eval('class Bar { constructor() {} }; Bar.toString()')", "'class Bar { constructor() {} }'");

shouldThrow("'use strict'; eval('class Bar { constructor() {} }'); Bar.toString()");