Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: test/mjsunit/harmony/block-conflicts-sloppy.js

Issue 1274193004: Let eval scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Changes for code review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scopes.h ('k') | test/webkit/class-syntax-name.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/block-conflicts-sloppy.js
diff --git a/test/mjsunit/harmony/block-conflicts-sloppy.js b/test/mjsunit/harmony/block-conflicts-sloppy.js
index 14dc24219ac85868710ac01ebe73f363aa7851de..9569c24ad4d60092f69ed73c2d9d18aede7eb196 100644
--- a/test/mjsunit/harmony/block-conflicts-sloppy.js
+++ b/test/mjsunit/harmony/block-conflicts-sloppy.js
@@ -44,12 +44,10 @@ function TestAll(expected,s,opt_e) {
var e = "";
var msg = s;
if (opt_e) { e = opt_e; msg += opt_e; }
- // TODO(littledan): https://code.google.com/p/v8/issues/detail?id=4288
- // It is also not clear whether these tests makes sense in sloppy mode.
// TODO(littledan): Add tests using Realm.eval to ensure that global eval
// works as expected.
- // assertEquals(expected === 'LocalConflict' ? 'NoConflict' : expected,
- // TestGlobal(s,e), "global:'" + msg + "'");
+ assertEquals(expected === 'LocalConflict' ? 'NoConflict' : expected,
+ TestGlobal(s,e), "global:'" + msg + "'");
assertEquals(expected === 'LocalConflict' ? 'NoConflict' : expected,
TestFunction(s,e), "function:'" + msg + "'");
assertEquals(expected === 'LocalConflict' ? 'Conflict' : expected,
@@ -59,22 +57,17 @@ function TestAll(expected,s,opt_e) {
function TestConflict(s) {
TestAll('Conflict', s);
- // TODO(littledan): https://code.google.com/p/v8/issues/detail?id=4288
- // It is also not clear whether these tests makes sense in sloppy mode.
- // TestAll('Conflict', 'eval("' + s + '");');
+ TestAll('Conflict', 'eval("' + s + '");');
}
function TestNoConflict(s) {
TestAll('NoConflict', s, "'NoConflict'");
- // TODO(littledan): https://code.google.com/p/v8/issues/detail?id=4288
- // TestAll('NoConflict', 'eval("' + s + '");', "'NoConflict'");
+ TestAll('NoConflict', 'eval("' + s + '");', "'NoConflict'");
}
function TestLocalConflict(s) {
TestAll('LocalConflict', s, "'NoConflict'");
- // TODO(littledan): https://code.google.com/p/v8/issues/detail?id=4288
- // It is also not clear whether these tests makes sense in sloppy mode.
- // TestAll('NoConflict', 'eval("' + s + '");', "'NoConflict'");
+ TestAll('NoConflict', 'eval("' + s + '");', "'NoConflict'");
}
var letbinds = [ "let x;",
« no previous file with comments | « src/scopes.h ('k') | test/webkit/class-syntax-name.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698