Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274073002: Apply custom scrollbar styles to the frame with root layer scrolling. (Closed)

Created:
5 years, 4 months ago by MuVen
Modified:
5 years, 4 months ago
Reviewers:
skobes
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, sivag
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply custom scrollbar styles to the frame with root layer scrolling. DeprecatedPaintLayerScrollableArea now checks for custom scrollbar styles on the body or html elements when constructing scrollbars for the root layer. BUG=487948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200429

Patch Set 1 : #

Patch Set 2 : With TestCase, Need(https://codereview.chromium.org/1273033002/) CL to check. #

Total comments: 3

Patch Set 3 : addressed review comments #

Patch Set 4 : document.documentElement.clientWidth/Height Not Calculated correctly #

Patch Set 5 : PixelRef Test !!! #

Patch Set 6 : addressed review comments #

Total comments: 6

Patch Set 7 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
A LayoutTests/fast/scrolling/custom-scrollbar-style-applied.html View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/scrolling/custom-scrollbar-style-applied-expected.txt View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 2 3 4 5 6 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
MuVen
Skobes, PTAL.
5 years, 4 months ago (2015-08-06 11:18:52 UTC) #5
skobes
https://codereview.chromium.org/1274073002/diff/70006/LayoutTests/scrollbars/custom-scrollbar-for-root-layer-scroll.html File LayoutTests/scrollbars/custom-scrollbar-for-root-layer-scroll.html (right): https://codereview.chromium.org/1274073002/diff/70006/LayoutTests/scrollbars/custom-scrollbar-for-root-layer-scroll.html#newcode3 LayoutTests/scrollbars/custom-scrollbar-for-root-layer-scroll.html:3: /* Let's get this party started */ Can you ...
5 years, 4 months ago (2015-08-06 20:09:32 UTC) #6
MuVen
PTAL.
5 years, 4 months ago (2015-08-07 09:43:27 UTC) #11
skobes
Your test file is identical to your -expected.html file, so the test would pass even ...
5 years, 4 months ago (2015-08-07 17:28:01 UTC) #12
skobes
Thanks, the test looks better. https://codereview.chromium.org/1274073002/diff/230001/LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html File LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html (right): https://codereview.chromium.org/1274073002/diff/230001/LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html#newcode35 LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html:35: description("Tests that Styles are ...
5 years, 4 months ago (2015-08-12 01:59:25 UTC) #13
MuVen
Done !!! PTAL. https://codereview.chromium.org/1274073002/diff/230001/LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html File LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html (right): https://codereview.chromium.org/1274073002/diff/230001/LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html#newcode35 LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html:35: description("Tests that Styles are applied to ...
5 years, 4 months ago (2015-08-12 07:15:10 UTC) #14
skobes
lgtm
5 years, 4 months ago (2015-08-12 17:44:07 UTC) #15
skobes
Please update the change description before submitting. It should be worded to express the effect ...
5 years, 4 months ago (2015-08-12 18:14:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274073002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274073002/250001
5 years, 4 months ago (2015-08-12 20:12:53 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 21:47:05 UTC) #19
Message was sent while issue was closed. 
Committed patchset #7 (id:250001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200429

Powered by Google App Engine
This is Rietveld 408576698