LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html - Issue 1274073002: Apply custom scrollbar styles to the frame with root layer scrolling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls.html

Issue 1274073002: Apply custom scrollbar styles to the frame with root layer scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/scrolling/custom-scrollbar-for-root-layer-scrolls-expected.txt » ('j') | Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 ::-webkit-scrollbar {

	5 width: 250px;

	6 height: 250px;

	7 }

	8 ::-webkit-scrollbar-track {

	9 -webkit-box-shadow: inset 0 0 6px rgba(0,0,0,0.3);

	10 -webkit-border-radius: 10px;

	11 border-radius: 10px;

	12 }

	13 ::-webkit-scrollbar-thumb {

	14 -webkit-border-radius: 1px;

	15 background: rgba(255,0,0,0.8);

	16 -webkit-box-shadow: inset 0 0 1px rgba(255,250,0,0.5);

	17 }

	18 #fill {

	19 background-color: #ccd;

	20 left: 0;

	21 top: 0;

	22 right: 0;

	23 bottom: 0;

	24 position: absolute;

	25 }

	26 #space {

	27 width: 1000px;

	28 height: 1000px;

	29 }

	30 </style>

	31 <div id="fill"></div>

	32 <div id="space"></div>

	33 <script>

	34 var fill = document.querySelector("#fill");

	35 description("Tests that Styles are applied to custom scrollbar on --root-layer -scrolls.");
	skobes 2015/08/12 01:59:25 The test will run in virtual/rootlayerscrolls, but The test will run in virtual/rootlayerscrolls, but it is not specific to root layer scrolling, so it shouldn't mention the flag in the description. (After the launch the flag will be removed but the test will stick around.) For the same reason, the filename should just be "custom-scrollbar-style-applied.html" or similar. MuVen 2015/08/12 07:15:09 Done. Show quoted text On 2015/08/12 01:59:25, skobes wrote: > The test will run in virtual/rootlayerscrolls, but it is not specific to root > layer scrolling, so it shouldn't mention the flag in the description. (After > the launch the flag will be removed but the test will stick around.) > > For the same reason, the filename should just be > "custom-scrollbar-style-applied.html" or similar. Done.
	36 shouldBe("fill.clientWidth", "550");

	37 shouldBe("fill.clientHeight", "350");

	38 </script>

OLD	NEW