Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1273813005: Revert of Fix cancellation of a pair of URLRequestJob subclasses (Closed)

Created:
5 years, 4 months ago by Peter Kasting
Modified:
5 years, 4 months ago
Reviewers:
davidben, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix cancellation of a pair of URLRequestJob subclasses (patchset #6 id:240001 of https://codereview.chromium.org/1271593002/ ) Reason for revert: Caused crashes in the following tests due to DCHECK failures: http/tests/serviceworker/registration.html http/tests/serviceworker/chromium/register-error-messages.html See e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)/builds/25550/steps/webkit_tests/logs/stdio for a log. Original issue's description: > Fix cancellation of a pair of URLRequestJob subclasses > > URLRequestSimpleJob and URLRequestChromeJob can call back into their > parent URLRequestJob class after Kill() has been invoked, which can > cause Bad Things. > > Longer term, we should think about the interface between URLRequestJob > and its subclasses, to see if we can create a more robust interface. > > BUG=508900 > > Committed: https://crrev.com/363ce98af274c07f43acac74b7ca7c23641c996e > Cr-Commit-Position: refs/heads/master@{#342211} TBR=davidben@chromium.org,mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508900 Committed: https://crrev.com/857c585526163ae1817352d6e9d805fbd07cb005 Cr-Commit-Position: refs/heads/master@{#342255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -146 lines) Patch
M content/browser/webui/url_data_manager_backend.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M content/browser/webui/url_data_manager_backend_unittest.cc View 1 chunk +32 lines, -85 lines 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/url_request/url_request_job.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/url_request/url_request_simple_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 3 chunks +16 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
Created Revert of Fix cancellation of a pair of URLRequestJob subclasses
5 years, 4 months ago (2015-08-07 01:22:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273813005/1
5 years, 4 months ago (2015-08-07 01:23:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 01:24:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/857c585526163ae1817352d6e9d805fbd07cb005 Cr-Commit-Position: refs/heads/master@{#342255}
5 years, 4 months ago (2015-08-07 01:25:04 UTC) #4
mmenke
5 years, 4 months ago (2015-08-07 02:14:18 UTC) #5
Message was sent while issue was closed.
Thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698