Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: net/url_request/url_request_http_job_unittest.cc

Issue 1273813005: Revert of Fix cancellation of a pair of URLRequestJob subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/webui/url_data_manager_backend_unittest.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 96e82bf6ae46c830a13f36e5dbee293f765e98a1..8df050202747c2ac1dab89c5248abd3b6ba52b34 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -391,6 +391,26 @@
EXPECT_EQ(HIGHEST, network_layer_.last_transaction()->priority());
}
+// Make sure that URLRequestHttpJob passes on its priority updates to
+// newly-created transactions after the first one.
+TEST_F(URLRequestHttpJobTest, SetSubsequentTransactionPriority) {
+ scoped_refptr<TestURLRequestHttpJob> job(
+ new TestURLRequestHttpJob(req_.get()));
+ job->Start();
+
+ job->SetPriority(LOW);
+ ASSERT_TRUE(network_layer_.last_transaction());
+ EXPECT_EQ(LOW, network_layer_.last_transaction()->priority());
+
+ job->Kill();
+ network_layer_.ClearLastTransaction();
+
+ // Creates a second transaction.
+ job->Start();
+ ASSERT_TRUE(network_layer_.last_transaction());
+ EXPECT_EQ(LOW, network_layer_.last_transaction()->priority());
+}
+
// Confirm we do advertise SDCH encoding in the case of a GET.
TEST_F(URLRequestHttpJobTest, SdchAdvertisementGet) {
EnableSdch();
« no previous file with comments | « content/browser/webui/url_data_manager_backend_unittest.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698