Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 127373003: [Telemetry] Some fixups in speed index calculation. (Closed)

Created:
6 years, 11 months ago by tonyg
Modified:
6 years, 11 months ago
Reviewers:
szym, dtu, qyearsley
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Some fixups in speed index calculation. 1. zIndex is case sensitive. Page contents were bleeding through on some pages. 2. With android screen capture compression artifacts, a slightly higher tolerance was needed. 3. The assert was wrong. We need to make sure the whole bounding box is filled. It doesn't matter what percent of the overall video is the bounding box. BUG=323813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244384

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +5 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
6 years, 11 months ago (2014-01-08 04:11:20 UTC) #1
szym
lgtm https://codereview.chromium.org/127373003/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/127373003/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode226 tools/telemetry/telemetry/core/platform/android_platform_backend.py:226: output = '' I'm surprised I didn't catch ...
6 years, 11 months ago (2014-01-09 19:37:31 UTC) #2
tonyg
https://codereview.chromium.org/127373003/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/127373003/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode226 tools/telemetry/telemetry/core/platform/android_platform_backend.py:226: output = '' On 2014/01/09 19:37:31, szym wrote: > ...
6 years, 11 months ago (2014-01-09 19:39:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/127373003/70001
6 years, 11 months ago (2014-01-11 02:00:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245237
6 years, 11 months ago (2014-01-11 05:48:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/127373003/70001
6 years, 11 months ago (2014-01-11 15:05:19 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 23:09:55 UTC) #7
Message was sent while issue was closed.
Change committed as 244384

Powered by Google App Engine
This is Rietveld 408576698