Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 127373003: [Telemetry] Some fixups in speed index calculation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/tab.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
index 755142e4a5112e1c920d1d919f037f6410c2d775..64c8f645c1a32d5ddc20604bf48c99d5dc9d8440 100644
--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
@@ -222,13 +222,17 @@ class AndroidPlatformBackend(
def GetDimensions(video):
proc = subprocess.Popen(['avconv', '-i', video], stderr=subprocess.PIPE)
+ dimensions = None
+ output = ''
for line in proc.stderr.readlines():
+ output += line
if 'Video:' in line:
dimensions = line.split(',')[2]
dimensions = map(int, dimensions.split()[0].split('x'))
break
proc.wait()
- assert dimensions, 'Failed to determine video dimensions'
+ assert dimensions, ('Failed to determine video dimensions. output=%s' %
+ output)
return dimensions
def GetFrameTimestampMs(stderr):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/tab.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698