Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 12737007: Merge 188631 "Don't throw exceptions when v8 objects/contexts ar..." (Closed)

Created:
7 years, 9 months ago by kareng
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Merge 188631 "Don't throw exceptions when v8 objects/contexts ar..." > Don't throw exceptions when v8 objects/contexts are missing, and catch > exceptions that are thrown on GC. There is a path crashing the renderer: > v8 GC -> run extension function -> throws exception -> webkit tries to log -> > context has been GCed -> crash. Try to avoid that. > > > BUG=196581 > R=mpcomplete@chromium.org > TBR=jhawkins@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12853007 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -78 lines) Patch
M chrome/browser/extensions/crazy_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + chrome/renderer/extensions/console.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/renderer/extensions/console.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 3 chunks +2 lines, -29 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/module_system.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/renderer/extensions/module_system.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M chrome/renderer/extensions/object_backed_native_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/crazy_extension/background.js View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 9 months ago (2013-03-17 14:02:34 UTC) #1
kareng
7 years, 9 months ago (2013-03-17 14:02:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r188638.

Powered by Google App Engine
This is Rietveld 408576698