Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6027)

Unified Diff: chrome/test/data/extensions/api_test/crazy_extension/background.js

Issue 12737007: Merge 188631 "Don't throw exceptions when v8 objects/contexts ar..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1443/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/object_backed_native_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/crazy_extension/background.js
===================================================================
--- chrome/test/data/extensions/api_test/crazy_extension/background.js (revision 188637)
+++ chrome/test/data/extensions/api_test/crazy_extension/background.js (working copy)
@@ -32,17 +32,12 @@
break;
}
case 2: {
- // Third test is that calling frame-dependent methods doesn't crash
- // the renderer if the frame doesn't exist anymore.
+ // Third test is that accessing API methods doesn't crash the
+ // renderer if the frame doesn't exist anymore.
+ // TODO(kalman): this fails. Fix.
var iframeChromeApp = iframe.contentWindow.chrome.app;
document.body.removeChild(iframe);
- var exception = null;
- try {
- iframeChromeApp.getDetails();
- } catch (e) {
- exception = e;
- }
- chrome.test.assertEq("Extension view no longer exists", exception);
+ chrome.test.assertEq(undefined, iframeChromeApp.getDetails);
chrome.test.succeed();
break;
}
« no previous file with comments | « chrome/renderer/extensions/object_backed_native_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698