Allow feedback form to be shown in an App Launcher feedback mode.

chrome/browser/resources/feedback.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Constants.
 /** @const */ var FEEDBACK_LANDING_PAGE =
     'https://www.google.com/support/chrome/go/feedback_confirmation';
 /** @const */ var MAX_ATTACH_FILE_SIZE = 3 * 1024 * 1024;
 
 var selectedThumbnailDivId = '';
@@ skipping 77 matching lines @@
   innerDiv.appendChild(thumbnail);
 
   thumbnailDiv.appendChild(innerDiv);
   $(divId).appendChild(thumbnailDiv);
 
   if (!selectedThumbnailId)
     selectImage(divId, thumbnailDiv.id);
 }
 
 /**
- * Disables screenshots completely.
+ * Shows the app launcher version of the feedback form.
+ */
+function showLauncherFeedback() {
+  $('page-url').hidden = true;

[Dan Beam, 2013/03/15 15:29:51]

nit: if you want, you can make a class called .launcher-showing and then do
something like:

  .launcher-showing #page-url,
  .launcher-showing #screenshot-row,
  .launcher-showing #title,
  .launcher-showing #description {
    display: none;
  }

  .launcher-showing #launcher-title,
  .launcher-showing #launcher-description {
    display: block;
  }

if you want, then here you'd do something like:

  document.documentElement.classList.add('launcher-showing');

it's kind of a toss up in my head, but we've previously used a single class as a
flag to affect many parts of the page

[rkc, 2013/03/15 16:58:40]

I'd strongly recommend that we go with the approach Dan outlined. We might have
more versions of the feedback page later on, having a class makes it cleaner to
implement in JS.

We could then have classes like,

.normal-feedback
.launcher-feedback
.settings-feedback

etc.

[benwells, 2013/03/18 05:21:19]

Done. Note I didn't roll the disabled / enabled screenshot into this. My
thinking is this layout control should be a top level thing only.

+  $('screenshot-row').hidden = true;
+  $('title').hidden = true;
+  $('description').hidden = true;
+  $('launcher-title').hidden = false;
+  $('launcher-description').hidden = false;
+}
+
+/**
+ * Enables screenshots.
  */
 function enableScreenshots() {
   if (forceDisableScreenshots)
     return;
   $('screenshot-row').hidden = false;
 }
 
 /**
  * Reads the selected file when the user selects a file.
  * @param {event} evtFileSelected The on changed event for the file input box.
@@ skipping 282 matching lines @@
 function setupDialogDefaults(defaults) {
   // Current url.
   if ($('page-url-text').value == '')
     $('page-url-text').value = defaults.currentUrl;
   if (defaults.currentUrl == '')
     $('page-url-checkbox').checked = false;
   // User e-mail.
   $('user-email-text').value = defaults.userEmail;
   $('user-email-checkbox').checked = defaults.emailCheckboxDefault;
 
-  // Are screenshots disabled?
-  if (!defaults.disableScreenshots)
+  if (defaults.launcherFeedback)
+    showLauncherFeedback();
+  else if (!defaults.disableScreenshots)
     enableScreenshots();
 
   if (defaults.useSaved) {
     $('screenshot-link-tosaved').hidden = false;
   }
 }
 
 window.addEventListener('DOMContentLoaded', load);