Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3239)

Unified Diff: chrome/browser/resources/feedback.js

Issue 12737006: Allow feedback form to be shown in an App Launcher feedback mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First round of feedback Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index b17cc1981254dccc24bfdbad80e8a0928425a572..ac0d26dc6fb288f681dbe4bc690a54afcb445bfd 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -95,7 +95,19 @@ function addScreenshot(divId, screenshot) {
}
/**
- * Disables screenshots completely.
+ * Shows the app launcher version of the feedback form.
+ */
+function showLauncherFeedback() {
+ $('page-url').hidden = true;
Dan Beam 2013/03/15 15:29:51 nit: if you want, you can make a class called .lau
rkc 2013/03/15 16:58:40 I'd strongly recommend that we go with the approac
benwells 2013/03/18 05:21:19 Done. Note I didn't roll the disabled / enabled sc
+ $('screenshot-row').hidden = true;
+ $('title').hidden = true;
+ $('description').hidden = true;
+ $('launcher-title').hidden = false;
+ $('launcher-description').hidden = false;
+}
+
+/**
+ * Enables screenshots.
*/
function enableScreenshots() {
if (forceDisableScreenshots)
@@ -398,8 +410,9 @@ function setupDialogDefaults(defaults) {
$('user-email-text').value = defaults.userEmail;
$('user-email-checkbox').checked = defaults.emailCheckboxDefault;
- // Are screenshots disabled?
- if (!defaults.disableScreenshots)
+ if (defaults.launcherFeedback)
+ showLauncherFeedback();
+ else if (!defaults.disableScreenshots)
enableScreenshots();
if (defaults.useSaved) {

Powered by Google App Engine
This is Rietveld 408576698