Issue 12734005: [Android WebView] Move C++ warnings to cflags_cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12734005: [Android WebView] Move C++ warnings to cflags_cc (Closed)

Created:
7 years, 9 months ago by benm (inactive)

Modified:
7 years, 9 months ago

Reviewers:
Torne

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only specify C++ warnings when building C++ code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187292

Patch Set 1 #

Patch Set 2 : Fix this properly #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	build/common.gypi	View	1 2 3	3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/12734005/18001

7 years, 9 months ago (2013-03-11 12:25:51 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=107241

7 years, 9 months ago (2013-03-11 13:29:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/12734005/18001

7 years, 9 months ago (2013-03-11 13:37:19 UTC) #5

benm (inactive)

7 years, 9 months ago (2013-03-11 13:59:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r187292 (presubmit successful).

Expand Messages | Collapse Messages