Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: build/common.gypi

Issue 12734005: [Android WebView] Move C++ warnings to cflags_cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d6144fcd590497a97600a17bd82226d1b1ba0a05..f22c58c51ed7e886133e9062136e2b5a336bee0b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3233,9 +3233,6 @@
'-Wno-extra', # Enabled by -Wextra, but no specific flag
'-Wno-ignored-qualifiers',
'-Wno-type-limits',
- # Other things unrelated to -Wextra:
- '-Wno-non-virtual-dtor',
- '-Wno-sign-promo',
],
'cflags_cc': [
# Disabling c++0x-compat should be handled in WebKit, but
@@ -3243,6 +3240,9 @@
# correctly when building with the Android build system.
# TODO(torne): Fix this in WebKit.
'-Wno-error=c++0x-compat',
+ # Other things unrelated to -Wextra:
+ '-Wno-non-virtual-dtor',
+ '-Wno-sign-promo',
],
}],
['android_build_type==1 and chromium_code==0', {
@@ -3250,14 +3250,15 @@
# There is a class of warning which:
# 1) Android always enables and also treats as errors
# 2) Chromium ignores in third party code
- # For now, I am leaving these warnings enabled but preventing
- # them from being treated as errors here.
+ # So we re-enable those warnings when building Android.
'-Wno-address',
'-Wno-format-security',
- '-Wno-non-virtual-dtor',
'-Wno-return-type',
'-Wno-sequence-point',
],
+ 'cflags_cc': [
+ '-Wno-non-virtual-dtor',
+ ]
}],
['target_arch == "arm"', {
'ldflags': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698