Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: src/hydrogen.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 404cfa7ee12d0830cab41d1fca99d567e625ccad..34d8c3d3fbac923dee3afc963138b81edad040e0 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -2129,25 +2129,10 @@ HValue* HGraphBuilder::BuildToObject(HValue* receiver) {
Context::SYMBOL_FUNCTION_INDEX));
Push(constructor);
}
- receiver_is_symbol.Else();
- {
- IfBuilder receiver_is_float32x4(this);
- receiver_is_float32x4.If<HCompareNumericAndBranch>(
- receiver_instance_type, Add<HConstant>(FLOAT32X4_TYPE),
- Token::EQ);
- receiver_is_float32x4.Then();
- {
- // Load global Float32x4 function.
- HValue* constructor = Add<HLoadNamedField>(
- native_context, nullptr,
- HObjectAccess::ForContextSlot(
- Context::FLOAT32X4_FUNCTION_INDEX));
- Push(constructor);
- }
- receiver_is_float32x4.ElseDeopt(
- Deoptimizer::kUndefinedOrNullInToObject);
- receiver_is_float32x4.JoinContinuation(&wrap);
- }
+ // TODO(bmeurer): Don't inline this into crankshaft code, as it will
+ // deoptimize on all SIMD128 objects.
+ receiver_is_symbol.ElseDeopt(
+ Deoptimizer::kUndefinedOrNullInToObject);
receiver_is_symbol.JoinContinuation(&wrap);
}
receiver_is_string.JoinContinuation(&wrap);
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698