Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1273313003: clang: Enable -Wfor-loop-analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to only -Wfor Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | media/cast/net/pacing/paced_sender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index b7d82a4687b72622526eb37c3334042756e9c5ef..e732de7779be8f77f2dd8c36c4434f1fce4c90a3 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -830,6 +830,12 @@ config("default_warnings") {
if (is_clang) {
cflags += [
+ # TODO(thakis): Add -Wfor-loop-analysis to -Wall in clang, remove this:
+ "-Wfor-loop-analysis",
+
+ # TODO(thakis): Consider -Wloop-analysis (turns on
+ # -Wrange-loop-analysis too).
+
# This warns on using ints as initializers for floats in
# initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
# which happens in several places in chrome code. Not sure if
« no previous file with comments | « build/common.gypi ('k') | media/cast/net/pacing/paced_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698