build/common.gypi - Issue 1273313003: clang: Enable -Wfor-loop-analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1273313003: clang: Enable -Wfor-loop-analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: back to only -Wfor Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 577a95c8fab7c9371cff47d161675af0f1cfa449..0c201a52b63b8f6573b21363e7894b712e1eae2b 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2633,6 +2633,12 @@

'clang_warning_flags': [

'-Wheader-hygiene',

+ # TODO(thakis): Add -Wfor-loop-analysis to -Wall in clang, remove this:

+ '-Wfor-loop-analysis',

+ # TODO(thakis): Consider -Wloop-analysis (turns on

+ # -Wrange-loop-analysis too).

# Don't die on dtoa code that uses a char as an array index.

# This is required solely for base/third_party/dmg_fp/dtoa.cc.

'-Wno-char-subscripts',

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »