clang: Enable -Wfor-loop-analysis.

clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pacing/paced_sender_unittest.cc
for examples.

BUG=none
TBR=imcheng

Committed: https://crrev.com/29ec253a32cc66d0855d8e6f17aafa00b1996a80
Cr-Commit-Position: refs/heads/master@{#367855}

[Nico, 2016-01-06 15:49:18]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

BUG=none
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

BUG=none
==========

[Nico, 2016-01-06 16:08:06]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

BUG=none
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

BUG=none
==========

[Nico, 2016-01-06 16:08:30]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2016-01-06 16:16:09]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

BUG=none
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
==========

[Nico, 2016-01-06 16:16:28]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2016-01-06 16:16:29]

+thestig, I think Hans is already out for today.

[hans, 2016-01-06 16:30:50]

lgtm

[Nico, 2016-01-06 16:50:44]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-01-06 16:51:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1273313003/130004
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1273313003/130004

[commit-bot: I haz the power, 2016-01-06 16:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 16:59:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-01-06 18:06:37]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
TBR=imcheng
==========

[Nico, 2016-01-06 18:06:58]

thakis@chromium.org changed reviewers:
+ imcheng@chromium.org

[Nico, 2016-01-06 18:06:58]

tbr imcheng for media/ (who said this is the right fix there in
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...)

[Nico, 2016-01-06 18:07:02]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:08:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1273313003/130004
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1273313003/130004

[commit-bot: I haz the power, 2016-01-06 18:13:56]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
TBR=imcheng
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
TBR=imcheng
==========

[commit-bot: I haz the power, 2016-01-06 18:13:57]

Committed patchset #8 (id:130004)

[commit-bot: I haz the power, 2016-01-06 18:14:57]

Description was changed from

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
TBR=imcheng
==========

to

==========
clang: Enable -Wfor-loop-analysis.

Every time I try this warning, it finds a few true positives
and has no false negatives.  It looks like an excellent
warning.

I did three builds of target "gfx" in both Release and Debug
with and without this warning enabled, doing local (non-goma)
component builds (running -t clean between each build). This
builds about 1.6k build steps each time.

Warning on:
Release: 0m26.850s 0m27.227s 0m27.159s
Debug: 0m24.811s 0m25.044s 0m25.498s

Warning off:
Release: 0m26.834s 0m27.242s 0m26.952s
Debug: 0m24.879s 0m25.064s 0m25.673s

See e.g. the comments in
https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellc...
https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pac...
for examples.

BUG=none
TBR=imcheng

Committed: https://crrev.com/29ec253a32cc66d0855d8e6f17aafa00b1996a80
Cr-Commit-Position: refs/heads/master@{#367855}
==========

[commit-bot: I haz the power, 2016-01-06 18:14:58]

Patchset 8 (id:??) landed as
https://crrev.com/29ec253a32cc66d0855d8e6f17aafa00b1996a80
Cr-Commit-Position: refs/heads/master@{#367855}

[imcheng, 2016-01-06 18:16:49]

media/cast/net/pacing/paced_sender_unittest.cc lgtm