Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: sync/engine/process_updates_util.cc

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Updating the recording macro. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/process_updates_util.cc
diff --git a/sync/engine/process_updates_util.cc b/sync/engine/process_updates_util.cc
index 9b428ef929bd9c8ba80705e028dd91f8ce2a39bb..ad0d30292dbb49c6ab0524bd041d4fb943f6ffed 100644
--- a/sync/engine/process_updates_util.cc
+++ b/sync/engine/process_updates_util.cc
@@ -15,6 +15,7 @@
#include "sync/syncable/syncable_proto_util.h"
#include "sync/syncable/syncable_util.h"
#include "sync/util/cryptographer.h"
+#include "sync/util/data_type_histogram.h"
namespace syncer {
@@ -303,6 +304,13 @@ void ProcessDownloadedUpdates(
if (verify_result != VERIFY_SUCCESS && verify_result != VERIFY_UNDELETE)
continue;
ProcessUpdate(**update_it, dir->GetCryptographer(trans), trans);
+ if ((*update_it)->ByteSize() > 0) {
+ SYNC_RECORD_DATATYPE_BIN("DataUse.Sync.Download.Bytes",
+ ModelTypeToHistogramInt(type),
+ (*update_it)->ByteSize());
+ }
+ UMA_HISTOGRAM_SPARSE_SLOWLY("DataUse.Sync.Download.Count",
+ ModelTypeToHistogramInt(type));
}
}

Powered by Google App Engine
This is Rietveld 408576698