Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: sync/engine/directory_update_handler.cc

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Updating the recording macro. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/directory_update_handler.cc
diff --git a/sync/engine/directory_update_handler.cc b/sync/engine/directory_update_handler.cc
index adcece7baf8294db03d533eb79d2c11bc13594ab..1c47a787383cf729ab787b55129fdc5733aadc9b 100644
--- a/sync/engine/directory_update_handler.cc
+++ b/sync/engine/directory_update_handler.cc
@@ -12,6 +12,7 @@
#include "sync/syncable/model_neutral_mutable_entry.h"
#include "sync/syncable/syncable_model_neutral_write_transaction.h"
#include "sync/syncable/syncable_write_transaction.h"
+#include "sync/util/data_type_histogram.h"
namespace syncer {
@@ -46,6 +47,11 @@ SyncerError DirectoryUpdateHandler::ProcessGetUpdatesResponse(
const SyncEntityList& applicable_updates,
sessions::StatusController* status) {
syncable::ModelNeutralWriteTransaction trans(FROM_HERE, SYNCER, dir_);
+ if (progress_marker.ByteSize() > 0) {
+ SYNC_RECORD_DATATYPE_BIN("DataUse.Sync.ProgressMarker.Bytes",
+ ModelTypeToHistogramInt(type_),
+ progress_marker.ByteSize());
+ }
if (mutated_context.has_context()) {
sync_pb::DataTypeContext local_context;
dir_->GetDataTypeContext(&trans, type_, &local_context);

Powered by Google App Engine
This is Rietveld 408576698