tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4cbed3453d0310875041e9fc37034b89906dede8..0a65b31208dba7665bffac1f764b7d5f95a6889a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5234,6 +5234,47 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DataUse.Sync.Download.Bytes" enum="DataUseSyncServiceType">
+  <owner>amohammadkhan@chromium.org</owner>
+  <summary>
+    Number of downloaded bytes of different data types in Sync service for

[Nicolas Zea, 2015/08/06 23:22:24]

What's the time window for each of these histograms?

[amohammadkhan, 2015/08/07 00:17:12]

They are updated with each update or commit for ModelTypes including in them.

+    received updates.
+  </summary>
+</histogram>
+
+<histogram name="DataUse.Sync.Download.Count" enum="DataUseSyncServiceType">
+  <owner>amohammadkhan@chromium.org</owner>
+  <summary>
+    Number of downloaded entities of different data types in Sync service for
+    received updates.
+  </summary>
+</histogram>
+
+<histogram name="DataUse.Sync.ProgressMarker.Bytes"

[Nicolas Zea, 2015/08/06 23:22:24]

I wouldn't expect the progress marker to be particular interesting. It's part of
each request, along with some other overhead we use to identify and enable the
request, but it doesn't grow in size.

[amohammadkhan, 2015/08/07 00:17:12]

I was looking for a way to record request for types that doesn't lead to a
update and "no update" is the response. Do you have any suggestion? and
basically do you think is it beneficial to know it?

[Nicolas Zea, 2015/08/07 22:57:36]

I'm not sure what you mean by "update and no update". Could you explain a bit
more what you're trying to do? But at a high level I don't think that the
progress marker itself is particularly interesting no.

[amohammadkhan, 2015/08/08 00:50:19]

If I have understood it right, sometimes Sync service on a client requests for
update, but no update exists. So no update is received and nothing is reflected
in our other histograms.
But the update request and received response are not small(They are at least few
KBs) and I thought the main contributors to this size are progressMakers so I
thought it may be a good idea to have statistics about them too.

+    enum="DataUseSyncServiceType">
+  <owner>amohammadkhan@chromium.org</owner>
+  <summary>
+    Number of downloaded bytes of ProgressMarker of different data types in Sync
+    service for received updates.
+  </summary>
+</histogram>
+
+<histogram name="DataUse.Sync.Upload.Bytes" enum="DataUseSyncServiceType">
+  <owner>amohammadkhan@chromium.org</owner>
+  <summary>
+    Number of uploaded bytes of different data types in Sync service for sent
+    commits.
+  </summary>
+</histogram>
+
+<histogram name="DataUse.Sync.Upload.Count" enum="DataUseSyncServiceType">
+  <owner>amohammadkhan@chromium.org</owner>
+  <summary>
+    Number of uploaded entities of different data types in Sync service for sent
+    commits.
+  </summary>
+</histogram>
+
 <histogram name="DataUse.User" units="bytes">
   <owner>amohammadkhan@chromium.org</owner>
   <summary>
@@ -53545,6 +53586,46 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="700836285" label="Suggestion Service"/>
 </enum>
 
+<enum name="DataUseSyncServiceType" type="int">

[Nicolas Zea, 2015/08/06 23:22:24]

There already exists a sync model type enum. We should reuse it

[amohammadkhan, 2015/08/07 00:17:12]

It seems that one doesn't match with the definition in the ModelType.h and it is
not updated.

+  <int value="0" label="Unspecified"/>
+  <int value="1" label="Top Level Folder"/>
+  <int value="2" label="Bookmarks"/>
+  <int value="3" label="Preferences"/>
+  <int value="4" label="Passwords"/>
+  <int value="5" label="Autofill Profile"/>
+  <int value="6" label="Autofill"/>
+  <int value="7" label="Autofill Wallet Data"/>
+  <int value="8" label="Autofill Wallet Metadata"/>
+  <int value="9" label="Themes"/>
+  <int value="10" label="Typed URLs"/>
+  <int value="11" label="Extensions"/>
+  <int value="12" label="Search Engines"/>
+  <int value="13" label="Sessions"/>
+  <int value="14" label="Apps"/>
+  <int value="15" label="App Settings"/>
+  <int value="16" label="Extention Settings"/>
+  <int value="17" label="App Notifications"/>
+  <int value="18" label="History Delete Directives"/>
+  <int value="19" label="Synced Notifications"/>
+  <int value="20" label="Synced Notification App Info"/>
+  <int value="21" label="Dictionary"/>
+  <int value="22" label="Favicon Images"/>
+  <int value="23" label="Favicon Tracking"/>
+  <int value="24" label="Device Info"/>
+  <int value="25" label="Priority Preferences"/>
+  <int value="26" label="Supervised User Settings"/>
+  <int value="27" label="Supervised Users"/>
+  <int value="28" label="Supervised Users shared settings"/>
+  <int value="29" label="Articles"/>
+  <int value="30" label="App List"/>
+  <int value="31" label="Wifi Credentials"/>
+  <int value="32" label="Supervised User Whitelist"/>
+  <int value="33" label="Proxy Tabs"/>
+  <int value="34" label="Nigori"/>
+  <int value="35" label="Experiments"/>
+  <int value="36" label="Model Type Count"/>
+</enum>
+
 <enum name="DecodedImageType" type="int">
   <int value="0" label="kImageUnknown"/>
   <int value="1" label="kImageJPEG"/>