Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: sync/engine/process_updates_util.cc

Issue 1273303002: Measuring data use of different ModelTypes in Sync Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewServices
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/process_updates_util.cc
diff --git a/sync/engine/process_updates_util.cc b/sync/engine/process_updates_util.cc
index 9b428ef929bd9c8ba80705e028dd91f8ce2a39bb..e0676f019547fdf92cfcc48ed2bcf4a4ed5b828a 100644
--- a/sync/engine/process_updates_util.cc
+++ b/sync/engine/process_updates_util.cc
@@ -5,6 +5,7 @@
#include "sync/engine/process_updates_util.h"
#include "base/location.h"
+#include "base/metrics/sparse_histogram.h"
#include "sync/engine/syncer_proto_util.h"
#include "sync/engine/syncer_types.h"
#include "sync/engine/syncer_util.h"
@@ -16,6 +17,13 @@
#include "sync/syncable/syncable_util.h"
#include "sync/util/cryptographer.h"
+#define UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE(name, sample, value) \
+ do { \
+ base::HistogramBase* histogram = base::SparseHistogram::FactoryGet( \
+ name, base::HistogramBase::kUmaTargetedHistogramFlag); \
+ histogram->AddCount(sample, value); \
+ } while (0)
+
namespace syncer {
using sessions::StatusController;
@@ -303,6 +311,11 @@ void ProcessDownloadedUpdates(
if (verify_result != VERIFY_SUCCESS && verify_result != VERIFY_UNDELETE)
continue;
ProcessUpdate(**update_it, dir->GetCryptographer(trans), trans);
+ if ((*update_it)->ByteSize() > 0)
bengr 2015/08/07 17:13:37 Add curly braces.
amohammadkhan 2015/08/07 18:52:30 Done.
+ UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE("DataUse.Sync.Download.Bytes",
+ type, (*update_it)->ByteSize());
+ UMA_HISTOGRAM_SPARSE_SLOWLY_WITH_VALUE("DataUse.Sync.Download.Count", type,
+ 1);
}
}

Powered by Google App Engine
This is Rietveld 408576698