Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1273263002: [Android WebView] Prepare loading error messages for TC (Closed)

Created:
5 years, 4 months ago by mnaganov (inactive)
Modified:
5 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Prepare loading error messages for TC While trying to hook up new strings from crrev.com/1270793002 into TC, I have realized that some changes need to be made to their definitions. 1. In Chrome, html fragments (grit 'structures') are not used. Instead, they just put into .grd files as regular messages, with markup being isolated inside fake placeholders to avoid the translators messing with it. (and grit also requires non-empty 'example' tags to present for them). Thus, removed 'structure.html' and put its contents into a scary-looking message. 2. .grd files containing messages must not include anything, as only .grd files themselves are copied into the internal tree for processing. Thus, split the messages into a separate .grd file with no includes. 3. From the strings .grd, per-locale .pak files must be produced, and then all those xxx_strings_xx.pak files repacked into a single xx.pak file. As WebView already uses content_strings, changed the script to pack content_strings together with the new strings, and renamed the script accordingly. 4. As I would not like to repeat this process again would we need some native strings on the browser part, and as we share native resources between the browser and the renderer, moved the .grd files out from 'renderer' into a new 'ui' subdir. BUG=515691 Committed: https://crrev.com/56917048940d4ecd4854416cee2901965320dc89 Cr-Commit-Position: refs/heads/master@{#342367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -189 lines) Patch
M android_webview/android_webview.gyp View 2 chunks +16 lines, -9 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 2 chunks +4 lines, -3 lines 0 comments Download
D android_webview/renderer/aw_renderer_resources.grd View 1 chunk +0 lines, -28 lines 0 comments Download
D android_webview/renderer/resources/load_error.html View 1 chunk +0 lines, -20 lines 0 comments Download
D android_webview/renderer/resources/suggestions.html View 1 chunk +0 lines, -6 lines 0 comments Download
D android_webview/tools/webview_locales_rename_paks.py View 1 chunk +0 lines, -98 lines 0 comments Download
A + android_webview/tools/webview_repack_locales.py View 2 chunks +33 lines, -24 lines 0 comments Download
A android_webview/ui/aw_resources.grd View 1 chunk +14 lines, -0 lines 0 comments Download
A android_webview/ui/aw_strings.grd View 1 chunk +78 lines, -0 lines 0 comments Download
A + android_webview/ui/resources/load_error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 4 months ago (2015-08-06 20:34:53 UTC) #2
Torne
lgtm
5 years, 4 months ago (2015-08-07 13:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273263002/1
5 years, 4 months ago (2015-08-07 15:28:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 16:48:44 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 16:49:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56917048940d4ecd4854416cee2901965320dc89
Cr-Commit-Position: refs/heads/master@{#342367}

Powered by Google App Engine
This is Rietveld 408576698