Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1273223002: Create DependencyManager API. (Closed)

Created:
5 years, 4 months ago by aiolos (Not reviewing)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@binary_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create DependencyManager API. This will be used in the telemetry binary_manager for the binary dependencies, and also the archive_info for the wpr and other dependency files. BUG=510231 Committed: https://crrev.com/a8028b341b17ad5a574dc706c89ea0ed06d1fe82 Cr-Commit-Position: refs/heads/master@{#342687}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ned comment nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A tools/telemetry/catapult_base/dependency_manager.py View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
aiolos (Not reviewing)
5 years, 4 months ago (2015-08-06 19:20:24 UTC) #3
aiolos (Not reviewing)
5 years, 4 months ago (2015-08-06 20:14:00 UTC) #5
nednguyen
lgtm https://codereview.chromium.org/1273223002/diff/1/tools/telemetry/catapult_base/dependency_manager.py File tools/telemetry/catapult_base/dependency_manager.py (right): https://codereview.chromium.org/1273223002/diff/1/tools/telemetry/catapult_base/dependency_manager.py#newcode49 tools/telemetry/catapult_base/dependency_manager.py:49: Return a path to the appropriate executable for ...
5 years, 4 months ago (2015-08-06 21:26:38 UTC) #6
eakuefner
lgtm
5 years, 4 months ago (2015-08-06 21:28:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/1
5 years, 4 months ago (2015-08-06 21:32:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89998)
5 years, 4 months ago (2015-08-06 23:31:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/1
5 years, 4 months ago (2015-08-10 17:01:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/20001
5 years, 4 months ago (2015-08-10 20:32:25 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 20:38:19 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 20:39:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8028b341b17ad5a574dc706c89ea0ed06d1fe82
Cr-Commit-Position: refs/heads/master@{#342687}

Powered by Google App Engine
This is Rietveld 408576698