Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 4 months ago by aiolos (Not reviewing) Modified:
5 years, 4 months ago Reviewers:
eakuefner, nednguyen, dtu, sullivan CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@binary_manager Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCreate DependencyManager API.
This will be used in the telemetry binary_manager for the binary dependencies, and also the archive_info for the wpr and other dependency files.
BUG=510231
Committed: https://crrev.com/a8028b341b17ad5a574dc706c89ea0ed06d1fe82
Cr-Commit-Position: refs/heads/master@{#342687}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Ned comment nit. #
Created: 5 years, 4 months ago
Messages
Total messages: 18 (8 generated)
aiolos@chromium.org changed reviewers: + eakuefner@chromium.org, nednguyen@google.com
aiolos@chromium.org changed reviewers: + sullivan@chromium.org
aiolos@chromium.org changed reviewers: + dtu@chromium.org
lgtm https://codereview.chromium.org/1273223002/diff/1/tools/telemetry/catapult_ba... File tools/telemetry/catapult_base/dependency_manager.py (right): https://codereview.chromium.org/1273223002/diff/1/tools/telemetry/catapult_ba... tools/telemetry/catapult_base/dependency_manager.py:49: Return a path to the appropriate executable for <dependency>, |dependency|
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/1
The CQ bit was checked by aiolos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/1273223002/#ps20001 (title: "Ned comment nit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273223002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a8028b341b17ad5a574dc706c89ea0ed06d1fe82 Cr-Commit-Position: refs/heads/master@{#342687} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
