unittest/AssemblerX8632/XmmArith.cpp - Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8632/XmmArith.cpp

Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes tests & make format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8632/XmmArith.cpp

diff --git a/unittest/AssemblerX8632/XmmArith.cpp b/unittest/AssemblerX8632/XmmArith.cpp

index 45ff3a97a1474a3d739201ad18631abf5a62849c..a85c8f9de6dafc9f0274ac0b871408d2f9ed810b 100644

--- a/unittest/AssemblerX8632/XmmArith.cpp

+++ b/unittest/AssemblerX8632/XmmArith.cpp

@@ -1072,7 +1072,7 @@ TEST_F(AssemblerX8632Test, Cvt) {

__ movups(XmmRegister::Encoded_Reg_##Dst, dwordAddress(T0)); \

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##GPR, \

Immediate(Inst##Size##SrcValue)); \

- __ cvt##Inst(IceType_f##Size, XmmRegister::Encoded_Reg_##Dst, \

+ __ cvt##Inst(IceType_f##Size, XmmRegister::Encoded_Reg_##Dst, IceType_i32, \

GPRRegister::Encoded_Reg_##GPR); \

AssembledTest test = assemble(); \

@@ -1092,7 +1092,7 @@ TEST_F(AssemblerX8632Test, Cvt) {

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##GPR, \

Immediate(Inst##Size##DstValue)); \

__ movups(XmmRegister::Encoded_Reg_##Src, dwordAddress(T0)); \

- __ cvt##Inst(IceType_f##Size, GPRRegister::Encoded_Reg_##GPR, \

+ __ cvt##Inst(IceType_i32, GPRRegister::Encoded_Reg_##GPR, IceType_f##Size, \

XmmRegister::Encoded_Reg_##Src); \

AssembledTest test = assemble(); \

@@ -1132,7 +1132,7 @@ TEST_F(AssemblerX8632Test, Cvt) {

const uint32_t T1 = allocateDword(); \

__ movups(XmmRegister::Encoded_Reg_##Dst, dwordAddress(T0)); \

- __ cvt##Inst(IceType_f##Size, XmmRegister::Encoded_Reg_##Dst, \

+ __ cvt##Inst(IceType_f##Size, XmmRegister::Encoded_Reg_##Dst, IceType_i32, \

dwordAddress(T1)); \

AssembledTest test = assemble(); \

@@ -1152,7 +1152,7 @@ TEST_F(AssemblerX8632Test, Cvt) {

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##GPR, \

Immediate(Inst##Size##DstValue)); \

- __ cvt##Inst(IceType_f##Size, GPRRegister::Encoded_Reg_##GPR, \

+ __ cvt##Inst(IceType_i32, GPRRegister::Encoded_Reg_##GPR, IceType_f##Size, \

dwordAddress(T0)); \

AssembledTest test = assemble(); \

« no previous file with comments | « unittest/AssemblerX8632/DataMov.cpp ('k') | unittest/AssemblerX8664/DataMov.cpp » ('j') | no next file with comments »