unittest/AssemblerX8632/DataMov.cpp - Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8632/DataMov.cpp

Issue 1273153002: Subzero. Native 64-bit int arithmetic on x86-64. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes tests & make format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8632/DataMov.cpp

diff --git a/unittest/AssemblerX8632/DataMov.cpp b/unittest/AssemblerX8632/DataMov.cpp

index cb2012e96398fc27c69f50ef655daabb08bbced8..d41acd1e5f5eaa4df93cdddf5ac782e3d881559a 100644

--- a/unittest/AssemblerX8632/DataMov.cpp

+++ b/unittest/AssemblerX8632/DataMov.cpp

@@ -538,7 +538,8 @@ TEST_F(AssemblerX8632Test, MovdToXmm) {

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Src, Immediate(Value)); \

__ movss(IceType_f64, XmmRegister::Encoded_Reg_##Dst, dwordAddress(T0)); \

- __ movd(XmmRegister::Encoded_Reg_##Dst, GPRRegister::Encoded_Reg_##Src); \

+ __ movd(IceType_i32, XmmRegister::Encoded_Reg_##Dst, \

+ GPRRegister::Encoded_Reg_##Src); \

AssembledTest test = assemble(); \

@@ -560,7 +561,7 @@ TEST_F(AssemblerX8632Test, MovdToXmm) {

const uint64_t V1 = 0xFFFFFFFF00000000ull; \

__ movss(IceType_f64, XmmRegister::Encoded_Reg_##Dst, dwordAddress(T1)); \

- __ movd(XmmRegister::Encoded_Reg_##Dst, dwordAddress(T0)); \

+ __ movd(IceType_i32, XmmRegister::Encoded_Reg_##Dst, dwordAddress(T0)); \

AssembledTest test = assemble(); \

@@ -609,7 +610,8 @@ TEST_F(AssemblerX8632Test, MovdFromXmm) {

const uint32_t V0 = Value; \

__ movss(IceType_f64, XmmRegister::Encoded_Reg_##Src, dwordAddress(T0)); \

- __ movd(GPRRegister::Encoded_Reg_##Dst, XmmRegister::Encoded_Reg_##Src); \

+ __ movd(IceType_i32, GPRRegister::Encoded_Reg_##Dst, \

+ XmmRegister::Encoded_Reg_##Src); \

AssembledTest test = assemble(); \

@@ -631,7 +633,7 @@ TEST_F(AssemblerX8632Test, MovdFromXmm) {

const uint32_t V1 = ~(Value); \

__ movss(IceType_f64, XmmRegister::Encoded_Reg_##Src, dwordAddress(T0)); \

- __ movd(dwordAddress(T1), XmmRegister::Encoded_Reg_##Src); \

+ __ movd(IceType_i32, dwordAddress(T1), XmmRegister::Encoded_Reg_##Src); \

AssembledTest test = assemble(); \

« no previous file with comments | « src/IceTargetLoweringX86BaseImpl.h ('k') | unittest/AssemblerX8632/XmmArith.cpp » ('j') | no next file with comments »