Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1273103002: Port SkTextureCompression opts to SkOpts (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port SkTextureCompression opts to SkOpts Pretty vanilla translation. I cleaned up who calls whom a little. Used to be utils -> opts -> utils, now it's just utils -> opts. I may follow up with a pass over the NEON code for readability and to clean up dead code. This turns on NEON A8->R11EAC conversion for ARMv8. Unit tests which now hit the NEON code still pass. I can't find any related bench. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/b6394746ff546a9c60d68e3be162cb38feffa803

Patch Set 1 #

Patch Set 2 : fmt #

Patch Set 3 : include path #

Total comments: 2

Patch Set 4 : update include_dirs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -412 lines) Patch
M gyp/opts.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/opts.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkOpts.h View 1 3 2 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkOpts.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
D src/opts/SkTextureCompression_opts.h View 1 chunk +0 lines, -21 lines 0 comments Download
D src/opts/SkTextureCompression_opts_arm.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D src/opts/SkTextureCompression_opts_neon.h View 1 chunk +0 lines, -14 lines 0 comments Download
D src/opts/SkTextureCompression_opts_neon.cpp View 1 chunk +0 lines, -239 lines 0 comments Download
D src/opts/SkTextureCompression_opts_none.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
A src/opts/SkTextureCompressor_opts.h View 1 chunk +267 lines, -0 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 3 chunks +2 lines, -9 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 1 4 chunks +18 lines, -47 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273103002/40001
5 years, 4 months ago (2015-08-06 14:42:06 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-06 14:49:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-06 14:49:26 UTC) #6
djsollen
lgtm with one nit https://codereview.chromium.org/1273103002/diff/40001/src/core/SkOpts.h File src/core/SkOpts.h (right): https://codereview.chromium.org/1273103002/diff/40001/src/core/SkOpts.h#newcode11 src/core/SkOpts.h:11: #include "../utils/SkTextureCompressor.h" utils is already ...
5 years, 4 months ago (2015-08-06 14:59:42 UTC) #8
mtklein_C
https://codereview.chromium.org/1273103002/diff/40001/src/core/SkOpts.h File src/core/SkOpts.h (right): https://codereview.chromium.org/1273103002/diff/40001/src/core/SkOpts.h#newcode11 src/core/SkOpts.h:11: #include "../utils/SkTextureCompressor.h" On 2015/08/06 14:59:42, djsollen wrote: > utils ...
5 years, 4 months ago (2015-08-06 15:08:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273103002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273103002/60001
5 years, 4 months ago (2015-08-06 15:08:51 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 15:17:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b6394746ff546a9c60d68e3be162cb38feffa803

Powered by Google App Engine
This is Rietveld 408576698