Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1273053003: build: Use lld-link instead of lld-link2. (Closed)

Created:
5 years, 4 months ago by pcc1
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Use lld-link instead of lld-link2. lld-link now refers to the new COFF linker on LLVM trunk, as the old linker has been removed. The only users of the use_lld flag will need to be using LLVM trunk anyway, as we do not ship lld binaries, so this change should not affect them. R=thakis@chromium.org BUG=506453 Committed: https://crrev.com/8ef7f0d88f354741ae0c56a3747667a325414852 Cr-Commit-Position: refs/heads/master@{#342224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
pcc1
5 years, 4 months ago (2015-08-06 19:20:13 UTC) #1
Nico
lgtm!
5 years, 4 months ago (2015-08-06 20:13:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273053003/1
5 years, 4 months ago (2015-08-06 20:20:01 UTC) #4
ruiu
Thank you for doing this!
5 years, 4 months ago (2015-08-06 20:24:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/82237) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 4 months ago (2015-08-06 20:44:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273053003/1
5 years, 4 months ago (2015-08-06 20:47:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/25411)
5 years, 4 months ago (2015-08-06 21:41:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273053003/1
5 years, 4 months ago (2015-08-06 22:09:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 23:06:20 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:06:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ef7f0d88f354741ae0c56a3747667a325414852
Cr-Commit-Position: refs/heads/master@{#342224}

Powered by Google App Engine
This is Rietveld 408576698