net/proxy/proxy_service.h - Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service.h

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service.h

diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h

index e0f807777d3fdb81a61d2d37282b8fafa51306b0..e09ced1f56972e005b8ffec0fb7dca5e5133451f 100644

--- a/net/proxy/proxy_service.h

+++ b/net/proxy/proxy_service.h

@@ -196,7 +196,7 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,

// ProxyService takes ownership of both objects.

eroman 2015/08/19 22:08:39 Can you update this comment to "ProxyService takes

Paritosh Kumar 2015/08/20 15:23:34 Done.

void SetProxyScriptFetchers(

ProxyScriptFetcher* proxy_script_fetcher,

- DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher);

+ scoped_ptr<DhcpProxyScriptFetcher> dhcp_proxy_script_fetcher);

ProxyScriptFetcher* GetProxyScriptFetcher() const;

// Tells this ProxyService to start using a new ProxyConfigService to

« net/proxy/dhcp_proxy_script_fetcher_factory.h ('K') | « net/proxy/dhcp_proxy_script_fetcher_factory.cc ('k') | net/proxy/proxy_service.cc » ('j') | net/proxy/proxy_service.cc » ('J')