net/proxy/proxy_service.cc - Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service.cc

Issue 1273013004: Returning scoped_ptr<> instead of raw pointer in DhcpProxyScriptFetcherFactory::Create (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service.cc

diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc

index 73ba0eec2a2d2bc57ba1927800a4cdeea824e9c9..f1aa1c890a23c3bbd565a7ccc19c7c3edc8bdbb4 100644

--- a/net/proxy/proxy_service.cc

+++ b/net/proxy/proxy_service.cc

@@ -1440,11 +1440,11 @@ int ProxyService::DidFinishResolvingProxy(const GURL& url,

void ProxyService::SetProxyScriptFetchers(

ProxyScriptFetcher* proxy_script_fetcher,

- DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher) {

+ scoped_ptr<DhcpProxyScriptFetcher> dhcp_proxy_script_fetcher) {

DCHECK(CalledOnValidThread());

State previous_state = ResetProxyConfig(false);

proxy_script_fetcher_.reset(proxy_script_fetcher);

- dhcp_proxy_script_fetcher_.reset(dhcp_proxy_script_fetcher);

+ dhcp_proxy_script_fetcher_.reset(dhcp_proxy_script_fetcher.release());

eroman 2015/08/19 22:08:39 dhcp_proxy_script_fetcher_ = dhcp_proxy_script_fet

Paritosh Kumar 2015/08/20 15:23:34 Done.

if (previous_state != STATE_NONE)

ApplyProxyConfigIfAvailable();

}

« net/proxy/proxy_service.h ('K') | « net/proxy/proxy_service.h ('k') | net/proxy/proxy_service_mojo.h » ('j') | net/proxy/proxy_service_mojo.h » ('J')