Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/ast-expression-visitor.cc

Issue 1272673003: [es6] Re-implement rest parameters via desugaring. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase + fix brokenness Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.h ('k') | src/ast-literal-reindexer.h » ('j') | src/parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast-expression-visitor.cc
diff --git a/src/ast-expression-visitor.cc b/src/ast-expression-visitor.cc
index 5a0912576155dd64cdde5556574a8281a1889a7a..1f6bddcdd895b54297057e03cf92c5924eb7b050 100644
--- a/src/ast-expression-visitor.cc
+++ b/src/ast-expression-visitor.cc
@@ -203,6 +203,11 @@ void AstExpressionVisitor::VisitVariableProxy(VariableProxy* expr) {
}
+void AstExpressionVisitor::VisitRestParameter(RestParameter* expr) {
adamk 2015/08/28 23:26:37 Why isn't this one UNREACHABLE()?
caitp (gmail) 2015/08/28 23:58:01 I wasn't sure if AstExpressionVisitor was ever use
caitp (gmail) 2015/08/29 15:51:59 All the AST node stuff is now gone, replaced with
+ VisitExpression(expr);
+}
+
+
void AstExpressionVisitor::VisitLiteral(Literal* expr) {
VisitExpression(expr);
}
« no previous file with comments | « src/ast.h ('k') | src/ast-literal-reindexer.h » ('j') | src/parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698