Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ast-expression-visitor.cc

Issue 1272673003: [es6] Re-implement rest parameters via desugaring. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase + fix brokenness Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast-expression-visitor.h" 7 #include "src/ast-expression-visitor.h"
8 8
9 #include "src/ast.h" 9 #include "src/ast.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 RECURSE(Visit(expr->then_expression())); 196 RECURSE(Visit(expr->then_expression()));
197 RECURSE(Visit(expr->else_expression())); 197 RECURSE(Visit(expr->else_expression()));
198 } 198 }
199 199
200 200
201 void AstExpressionVisitor::VisitVariableProxy(VariableProxy* expr) { 201 void AstExpressionVisitor::VisitVariableProxy(VariableProxy* expr) {
202 VisitExpression(expr); 202 VisitExpression(expr);
203 } 203 }
204 204
205 205
206 void AstExpressionVisitor::VisitRestParameter(RestParameter* expr) {
adamk 2015/08/28 23:26:37 Why isn't this one UNREACHABLE()?
caitp (gmail) 2015/08/28 23:58:01 I wasn't sure if AstExpressionVisitor was ever use
caitp (gmail) 2015/08/29 15:51:59 All the AST node stuff is now gone, replaced with
207 VisitExpression(expr);
208 }
209
210
206 void AstExpressionVisitor::VisitLiteral(Literal* expr) { 211 void AstExpressionVisitor::VisitLiteral(Literal* expr) {
207 VisitExpression(expr); 212 VisitExpression(expr);
208 } 213 }
209 214
210 215
211 void AstExpressionVisitor::VisitRegExpLiteral(RegExpLiteral* expr) { 216 void AstExpressionVisitor::VisitRegExpLiteral(RegExpLiteral* expr) {
212 VisitExpression(expr); 217 VisitExpression(expr);
213 } 218 }
214 219
215 220
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 347
343 void AstExpressionVisitor::VisitSuperPropertyReference( 348 void AstExpressionVisitor::VisitSuperPropertyReference(
344 SuperPropertyReference* expr) {} 349 SuperPropertyReference* expr) {}
345 350
346 351
347 void AstExpressionVisitor::VisitSuperCallReference(SuperCallReference* expr) {} 352 void AstExpressionVisitor::VisitSuperCallReference(SuperCallReference* expr) {}
348 } 353 }
349 354
350 355
351 } // namespace v8::internal 356 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/ast-literal-reindexer.h » ('j') | src/parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698