Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1272603003: Sync TouchEvent interfaces with the latest editors draft spec (Closed)

Created:
5 years, 4 months ago by Rick Byers
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-dom_chromium.org, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync TouchEvent interfaces with the latest editors draft spec BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200320

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added todos for constructors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/dom/Touch.idl View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/TouchList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/TouchEvent.idl View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Rick Byers
We've finished doing some cleanups / re-organization to the W3C TouchEvents GitHub repo. Seems like ...
5 years, 4 months ago (2015-08-10 16:39:06 UTC) #2
philipj_slow
lgtm https://codereview.chromium.org/1272603003/diff/1/Source/core/dom/Touch.idl File Source/core/dom/Touch.idl (right): https://codereview.chromium.org/1272603003/diff/1/Source/core/dom/Touch.idl#newcode30 Source/core/dom/Touch.idl:30: ] interface Touch { TODO constructor? Looks like ...
5 years, 4 months ago (2015-08-11 08:33:23 UTC) #3
Rick Byers
On 2015/08/11 08:33:23, philipj wrote: > lgtm > > https://codereview.chromium.org/1272603003/diff/1/Source/core/dom/Touch.idl > File Source/core/dom/Touch.idl (right): > ...
5 years, 4 months ago (2015-08-11 14:08:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272603003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272603003/20001
5 years, 4 months ago (2015-08-11 14:09:17 UTC) #7
philipj_slow
On 2015/08/11 14:08:42, Rick Byers wrote: > On 2015/08/11 08:33:23, philipj wrote: > > Looks ...
5 years, 4 months ago (2015-08-11 15:03:05 UTC) #8
Rick Byers
On 2015/08/11 15:03:05, philipj wrote: > On 2015/08/11 14:08:42, Rick Byers wrote: > > On ...
5 years, 4 months ago (2015-08-11 15:19:53 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 15:40:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200320

Powered by Google App Engine
This is Rietveld 408576698