Fixed 2 bugs so that RequestDevice() works for non-paired devices

Corrected the key used on |advertisement_data| in
BluetoothLowEnergyDeviceMac::Update(...) so that service UUIDs
are properly queried.

Also stopped clearing the device's |advertised_uuids_| in Update(...) because
CoreBluetooth returns the device data in separate chunks, and previous service
UUIDs were being cleared before we reported them.

BUG=516608
Committed: https://crrev.com/4847d81140922c2b5530e6c05ac3c1c020049c1c
Cr-Commit-Position: refs/heads/master@{#342172}

[krstnmnlsn, 2015-08-04 21:56:30]

krstnmnlsn@chromium.org changed reviewers:
+ scheib@chromium.org

[krstnmnlsn, 2015-08-04 23:47:42]

:)

[scheib, 2015-08-05 00:04:35]

LGTM with:

https://codereview.chromium.org/1272503002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1272503002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_low_energy_device_mac.mm:127:
BluetoothDevice::UUIDList advertised_uuids_list;
Hmm.. yep, have to either make copies here... or keep a vector and test for
inclusion... or keep a vector and a set and use the set to test. OK, probably
what's going on here is fine, but let's use std::vector's constructor to make
the copy of the set:

return BluetoothDevice::UUIDList(advertised_uuids_.begin(),
advertised_uuids_.end());

[krstnmnlsn, 2015-08-05 16:44:08]

krstnmnlsn@chromium.org changed reviewers:
+ armansito@chromium.org

[krstnmnlsn, 2015-08-05 16:44:09]

Hey Arman, fixing RequestDevice()!  Please review as soon as you can

https://codereview.chromium.org/1272503002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1272503002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_low_energy_device_mac.mm:127:
BluetoothDevice::UUIDList advertised_uuids_list;
On 2015/08/05 00:04:35, scheib wrote:
> Hmm.. yep, have to either make copies here... or keep a vector and test for
> inclusion... or keep a vector and a set and use the set to test. OK, probably
> what's going on here is fine, but let's use std::vector's constructor to make
> the copy of the set:
> 
> return BluetoothDevice::UUIDList(advertised_uuids_.begin(),
> advertised_uuids_.end());

Done.

[armansito, 2015-08-05 22:31:45]

lgtm

[krstnmnlsn, 2015-08-06 00:27:26]

The CQ bit was checked by krstnmnlsn@chromium.org

[krstnmnlsn, 2015-08-06 00:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1272503002/#ps20001
(title: "scheib fix")

[commit-bot: I haz the power, 2015-08-06 00:28:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272503002/20001

[commit-bot: I haz the power, 2015-08-06 00:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 00:39:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[krstnmnlsn, 2015-08-06 07:20:34]

krstnmnlsn@chromium.org changed reviewers:
+ thakis@chromium.org

[krstnmnlsn, 2015-08-06 07:20:35]

Hey Nico here is the CL.  I'm just adding 2 constants to
sdk_forward_declarations because I'm using them to grab service uuids from the
corebluetooth advertisement data.

Thank you!

[Nico, 2015-08-06 16:34:54]

base/ lgtm

[krstnmnlsn, 2015-08-06 17:27:44]

The CQ bit was checked by krstnmnlsn@chromium.org

[commit-bot: I haz the power, 2015-08-06 17:28:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272503002/20001

[commit-bot: I haz the power, 2015-08-06 19:11:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-06 19:12:40]

Patchset 2 (id:??) landed as
https://crrev.com/4847d81140922c2b5530e6c05ac3c1c020049c1c
Cr-Commit-Position: refs/heads/master@{#342172}