Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1260533003: BluetoothTest.* tests in bluetooth_device_unittests.cc run on Mac (Closed)

Created:
5 years, 5 months ago by krstnmnlsn
Modified:
5 years, 4 months ago
Reviewers:
scheib, armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled 2 device tests to run on OS X (> 10.10) and adjusted android and mac device default values to agree. BUG=511008 Committed: https://crrev.com/316b15d91d01ff2b78eded868de47b2eda2a02cd Cr-Commit-Position: refs/heads/master@{#341567}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M device/bluetooth/bluetooth_device_unittest.cc View 4 chunks +20 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 2 chunks +9 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
krstnmnlsn
smaller patch enabling the device tests.
5 years, 5 months ago (2015-07-24 18:27:05 UTC) #2
scheib
LGTM
5 years, 5 months ago (2015-07-24 23:30:55 UTC) #3
krstnmnlsn
Hey Arman, here is yet another testing CL! Please review (this and the previous, https://codereview.chromium.org/1246913006/ ...
5 years, 4 months ago (2015-07-27 17:29:07 UTC) #5
armansito
lgtm
5 years, 4 months ago (2015-07-28 00:55:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260533003/20001
5 years, 4 months ago (2015-08-03 18:09:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 18:46:36 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:47:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/316b15d91d01ff2b78eded868de47b2eda2a02cd
Cr-Commit-Position: refs/heads/master@{#341567}

Powered by Google App Engine
This is Rietveld 408576698