Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

components/favicon/core/favicon_driver.h

Index: components/favicon/core/favicon_driver.h
diff --git a/components/favicon/core/favicon_driver.h b/components/favicon/core/favicon_driver.h
index 986ad391c46902c3a2befb72ac1321edb02e3a4e..c21b6112c750e5efe0cf5c0bec0ca988d21a7da7 100644
--- a/components/favicon/core/favicon_driver.h
+++ b/components/favicon/core/favicon_driver.h
@@ -62,15 +62,14 @@ class FaviconDriver {
   virtual GURL GetActiveURL() = 0;
 
   // Returns whether the page's favicon is valid (returns false if the default
-  // favicon is being used). Requires GetActiveURL() to be valid.
+  // favicon is being used).
   virtual bool GetActiveFaviconValidity() = 0;
 
   // Sets whether the page's favicon is valid (if false, the default favicon is
   // being used).
   virtual void SetActiveFaviconValidity(bool valid) = 0;
 
-  // Returns the URL of the current page's favicon. Requires GetActiveURL() to
-  // be valid.
+  // Returns the URL of the current page's favicon.
   virtual GURL GetActiveFaviconURL() = 0;
 
   // Sets the URL of the favicon's bitmap.
@@ -79,6 +78,10 @@ class FaviconDriver {
   // Sets the bitmap of the current page's favicon.
   virtual void SetActiveFaviconImage(const gfx::Image& image) = 0;
 
+  // Returns whether any notifications should be sent when a favicon image is
+  // available.
+  virtual bool ShouldSendFaviconAvailableNotifications() = 0;

[sky, 2015/09/11 15:27:15]

This feels awkward. Why not cancel the fetch?

[pkotwicz, 2015/09/11 17:39:58]

It is awkward. In order to cancel the fetch we need to somehow get notified when
the active URL changes. I do not know how to get notified when the active URL
changes on iOS (Looking at the iOS code base this does not seem straightforward)

Personally, I am ok with this awkwardness on iOS for now. The correct thing to
do in the long term is to make iOS call FetchFavicon() at the same times as all
of the other OSes do. Landing this CL clears the way for further simplification
of FaviconHandler too

[sky, 2015/09/11 19:53:21]

I'm not familiar with the iOS code. Might rohitrao know the answer?

+
   // Notifies the driver a favicon image is available. |image| is not
   // necessarily 16x16. |icon_url| is the url the image is from. If
   // |is_active_favicon| is true the image corresponds to the favicon