Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

components/favicon/core/favicon_driver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
@@ skipping 44 matching lines @@
   virtual bool IsOffTheRecord() = 0;
 
   // Returns whether |url| is bookmarked.
   virtual bool IsBookmarked(const GURL& url) = 0;
 
   // Returns the URL of the current page, if any. Returns an invalid URL
   // otherwise.
   virtual GURL GetActiveURL() = 0;
 
   // Returns whether the page's favicon is valid (returns false if the default
-  // favicon is being used). Requires GetActiveURL() to be valid.
+  // favicon is being used).
   virtual bool GetActiveFaviconValidity() = 0;
 
   // Sets whether the page's favicon is valid (if false, the default favicon is
   // being used).
   virtual void SetActiveFaviconValidity(bool valid) = 0;
 
-  // Returns the URL of the current page's favicon. Requires GetActiveURL() to
-  // be valid.
+  // Returns the URL of the current page's favicon.
   virtual GURL GetActiveFaviconURL() = 0;
 
   // Sets the URL of the favicon's bitmap.
   virtual void SetActiveFaviconURL(const GURL& url) = 0;
 
   // Sets the bitmap of the current page's favicon.
   virtual void SetActiveFaviconImage(const gfx::Image& image) = 0;
 
+  // Returns whether any notifications should be sent when a favicon image is
+  // available.
+  virtual bool ShouldSendFaviconAvailableNotifications() = 0;

[sky, 2015/09/11 15:27:15]

This feels awkward. Why not cancel the fetch?

[pkotwicz, 2015/09/11 17:39:58]

It is awkward. In order to cancel the fetch we need to somehow get notified when
the active URL changes. I do not know how to get notified when the active URL
changes on iOS (Looking at the iOS code base this does not seem straightforward)

Personally, I am ok with this awkwardness on iOS for now. The correct thing to
do in the long term is to make iOS call FetchFavicon() at the same times as all
of the other OSes do. Landing this CL clears the way for further simplification
of FaviconHandler too

[sky, 2015/09/11 19:53:21]

I'm not familiar with the iOS code. Might rohitrao know the answer?

+
   // Notifies the driver a favicon image is available. |image| is not
   // necessarily 16x16. |icon_url| is the url the image is from. If
   // |is_active_favicon| is true the image corresponds to the favicon
   // (possibly empty) of the page.
   virtual void OnFaviconAvailable(const gfx::Image& image,
                                   const GURL& icon_url,
                                   bool is_active_favicon) = 0;
 
   // Returns whether the driver is waiting for a download to complete or for
   // data from the FaviconService. Reserved for testing.
@@ skipping 14 matching lines @@
 
  private:
   base::ObserverList<FaviconDriverObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(FaviconDriver);
 };
 
 }  // namespace favicon
 
 #endif  // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_