Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon/core/favicon_driver_impl.cc

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver.h ('k') | components/favicon/core/favicon_handler.h » ('j') | components/favicon/ios/web_favicon_driver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.cc
diff --git a/components/favicon/core/favicon_driver_impl.cc b/components/favicon/core/favicon_driver_impl.cc
index 260ec42d23d8af8565b70255d2b5dc0abedbd5a1..4de176ccab579d3fb4520448d3652645890e3625 100644
--- a/components/favicon/core/favicon_driver_impl.cc
+++ b/components/favicon/core/favicon_driver_impl.cc
@@ -101,6 +101,9 @@ bool FaviconDriverImpl::IsBookmarked(const GURL& url) {
void FaviconDriverImpl::OnFaviconAvailable(const gfx::Image& image,
const GURL& icon_url,
bool is_active_favicon) {
+ if (!ShouldSendFaviconAvailableNotifications())
+ return;
+
if (is_active_favicon) {
bool icon_url_changed = GetActiveFaviconURL() != icon_url;
// No matter what happens, we need to mark the favicon as being set.
« no previous file with comments | « components/favicon/core/favicon_driver.h ('k') | components/favicon/core/favicon_handler.h » ('j') | components/favicon/ios/web_favicon_driver.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698