Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/favicon/core/favicon_driver.h

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_driver.h
diff --git a/components/favicon/core/favicon_driver.h b/components/favicon/core/favicon_driver.h
index 977f5aa0d788d8fbd227a6e69c80c1cd6ded1787..29a056a3f079cd627295419d5d59c08cefaa20c5 100644
--- a/components/favicon/core/favicon_driver.h
+++ b/components/favicon/core/favicon_driver.h
@@ -65,15 +65,14 @@ class FaviconDriver {
virtual GURL GetActiveURL() = 0;
// Returns whether the page's favicon is valid (returns false if the default
- // favicon is being used). Requires GetActiveURL() to be valid.
+ // favicon is being used).
virtual bool GetActiveFaviconValidity() = 0;
// Sets whether the page's favicon is valid (if false, the default favicon is
// being used).
virtual void SetActiveFaviconValidity(bool valid) = 0;
- // Returns the URL of the current page's favicon. Requires GetActiveURL() to
- // be valid.
+ // Returns the URL of the current page's favicon.
virtual GURL GetActiveFaviconURL() = 0;
// Sets the URL of the favicon's bitmap.
@@ -82,6 +81,10 @@ class FaviconDriver {
// Sets the bitmap of the current page's favicon.
virtual void SetActiveFaviconImage(const gfx::Image& image) = 0;
+ // Returns whether any notifications should be sent when a favicon image is
+ // available.
+ virtual bool ShouldSendFaviconAvailableNotifications() = 0;
+
// Notifies the driver a favicon image is available. |image| is not
// necessarily 16x16. |icon_url| is the url the image is from. If
// |is_active_favicon| is true the image corresponds to the favicon

Powered by Google App Engine
This is Rietveld 408576698