Move SkTemplates.h to private.

Move SkTemplates.h to private.

SkTemplates.h contains a number of Skia specific utilities which are
not designed for external use. In addition to reducing the external
support burden, this will allow Skia to freely refactor this file.

Committed: https://skia.googlesource.com/skia/+/f3c15b7cfc4eed2528f7db87ea6c1444b55ee856

[bungeman-skia, 2015-08-06 17:15:44]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-06 17:15:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272293004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272293004/1

[commit-bot: I haz the power, 2015-08-06 17:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 17:18:36]

Dry run: Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

[bungeman-skia, 2015-08-06 20:04:37]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-06 20:04:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272293004/20001

[commit-bot: I haz the power, 2015-08-06 20:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 20:12:16]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-08-19 18:17:59]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 18:18:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272293004/80001

[commit-bot: I haz the power, 2015-08-19 18:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 18:20:06]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[bungeman-skia, 2015-08-19 18:23:29]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 18:23:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272293004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272293004/100001

[bungeman-skia, 2015-08-19 18:29:54]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2015-08-19 18:29:55]

This should now play nice with Chromium and Android.

https://codereview.chromium.org/1272293004/diff/20001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/1272293004/diff/20001/gyp/tools.gyp#newcode166
gyp/tools.gyp:166: 'xcode_settings': {
This makes this particular change work. I tried putting this in a
target_defaults, both in this file and in apptype_console.gypi, but that doesn't
seem to work. That adds CLANG_CXX_LIBRARY, but will not override
MACOSX_DEPLOYMENT_TARGET. I think we'll need to figure that out later.

https://codereview.chromium.org/1272293004/diff/40001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1272293004/diff/40001/include/core/SkPostConf...
include/core/SkPostConfig.h:104: #  include <new>
Forward declaring instead of including SkBitmapProcState in SkBitmapProcShader.h
caused SkSmallAllocator.h to start failing, because the SkNEW_PLACEMENT
placement macros use placement new, which requires including <new>. So include
it here so that users can use SkNEW_PLACEMENT without also including <new>
themselves.

https://codereview.chromium.org/1272293004/diff/40001/src/core/SkBitmapProcSh...
File src/core/SkBitmapProcShader.h (right):

https://codereview.chromium.org/1272293004/diff/40001/src/core/SkBitmapProcSh...
src/core/SkBitmapProcShader.h:16: class SkBitmapProcState;
This was done because chromium/src/skia/ext/pixel_ref_utils.cc includes
skia/src/core/SkRasterClip.h which is trying to pull in SkTemplates.h through
the SkBitmapProcState.h include here before. The pixel_ref_utils should not be
including from skia/src anyway, but this dependency can be broken by a forward
declare here.

[commit-bot: I haz the power, 2015-08-19 18:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 18:30:16]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-08-19 18:44:55]

lgtm

[mtklein, 2015-08-19 18:55:42]

lgtm

[mtklein, 2015-08-19 18:56:00]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-08-19 18:56:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272293004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272293004/100001

[commit-bot: I haz the power, 2015-08-19 18:56:52]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/f3c15b7cfc4eed2528f7db87ea6c1444b55ee856