Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 1272283003: Add a new SpdyStream::Delegate method to handle trailers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ryan's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_proxy_client_socket.cc
diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc
index 39fbd60cf33d0e7e0a77d7c7f1fc87508ec1d85e..64b54a412282f6ff553e541aa7a90f8d93d7e7b9 100644
--- a/net/spdy/spdy_proxy_client_socket.cc
+++ b/net/spdy/spdy_proxy_client_socket.cc
@@ -496,6 +496,8 @@ void SpdyProxyClientSocket::OnDataSent() {
ResetAndReturn(&write_callback_), rv));
}
+void SpdyProxyClientSocket::OnTrailers(const SpdyHeaderBlock& trailers) {}
Ryan Hamilton 2015/08/10 22:37:38 Ignoring headers is fine, though you could also cl
xunjieli 2015/08/11 15:07:14 I added a comment. I am not sure how to close the
Ryan Hamilton 2015/08/11 16:30:09 Hm. Good question :> Perhaps leaving it alone is f
xunjieli 2015/08/11 17:58:11 Done. You are right -- the proxy client socket's S
+
void SpdyProxyClientSocket::OnClose(int status) {
was_ever_used_ = spdy_stream_->WasEverUsed();
spdy_stream_.reset();

Powered by Google App Engine
This is Rietveld 408576698