Add a new SpdyStream::Delegate method to handle trailers

net/spdy/spdy_proxy_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_proxy_client_socket.h"
 
 #include <algorithm>  // min
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 478 matching lines @@
   write_buffer_len_ = 0;
 
   // Proxy write callbacks result in deep callback chains. Post to allow the
   // stream's write callback chain to unwind (see crbug.com/355511).
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(&SpdyProxyClientSocket::RunCallback,
                             write_callback_weak_factory_.GetWeakPtr(),
                             ResetAndReturn(&write_callback_), rv));
 }
 
+void SpdyProxyClientSocket::OnTrailers(const SpdyHeaderBlock& trailers) {}

[Ryan Hamilton, 2015/08/10 22:37:38]

Ignoring headers is fine, though you could also close the connection with some
sort of error, if you wish. I can't imagine trailers make any sense for a
CONNECT tunnel.

[xunjieli, 2015/08/11 15:07:14]

I added a comment. I am not sure how to close the connection with an error.
There's a Disconnect() method, but it only resets the stream with
STATUS_CODE_CANCEL. Should we do that here? 

[Ryan Hamilton, 2015/08/11 16:30:09]

Hm. Good question :> Perhaps leaving it alone is fine. Now that I think about
it, I don't that the proxy client socket's SpdyStream is a
REQUEST_RESPONSE_STREAM, so perhaps you can just put NOTREACHED() here, but
OnTrailers() will never be called?

[xunjieli, 2015/08/11 17:58:11]

Done. You are right -- the proxy client socket's SpdyStream is of type
SPDY_BIDIRECTIONAL_STREAM, so trailers will be combined with response headers.
NOTREACHED here makes sense.

+
 void SpdyProxyClientSocket::OnClose(int status)  {
   was_ever_used_ = spdy_stream_->WasEverUsed();
   spdy_stream_.reset();
 
   bool connecting = next_state_ != STATE_DISCONNECTED &&
       next_state_ < STATE_OPEN;
   if (next_state_ == STATE_OPEN)
     next_state_ = STATE_CLOSED;
   else
     next_state_ = STATE_DISCONNECTED;
@@ skipping 13 matching lines @@
   } else if (!read_callback_.is_null()) {
     // If we have a read_callback_, the we need to make sure we call it back.
     OnDataReceived(scoped_ptr<SpdyBuffer>());
   }
   // This may have been deleted by read_callback_, so check first.
   if (weak_ptr.get() && !write_callback.is_null())
     write_callback.Run(ERR_CONNECTION_CLOSED);
 }
 
 }  // namespace net