net/quic/quic_crypto_server_stream_test.cc - Issue 1272153006: relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 1272153006: relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deprecate_flag_quic_send_fec_packet_only_on_fec_alarm_99599597

Patch Set: Disabled FLAGS_quic_require_handshake_confirmation for ZeroRTT test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_crypto_server_stream_test.cc

diff --git a/net/quic/quic_crypto_server_stream_test.cc b/net/quic/quic_crypto_server_stream_test.cc

index a60fcaae5a29e3d8a2302b053366e3e17122cdf7..9203f17ad7be0b3e1a109021f45f3f852a306485 100644

--- a/net/quic/quic_crypto_server_stream_test.cc

+++ b/net/quic/quic_crypto_server_stream_test.cc

@@ -299,6 +299,8 @@ TEST_P(QuicCryptoServerStreamTest, NoStatelessRejectIfNoClientSupport) {

}

TEST_P(QuicCryptoServerStreamTest, ZeroRTT) {

+ ValueRestore<bool> old_flag(&FLAGS_quic_require_handshake_confirmation,

+ false);

InitializeFakeClient(/* supports_stateless_rejects= */ false);

// Do a first handshake in order to prime the client config with the server's

« no previous file with comments | « net/quic/crypto/quic_crypto_server_config.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »