Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 1272153006: relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deprecate_flag_quic_send_fec_packet_only_on_fec_alarm_99599597
Patch Set: Disabled FLAGS_quic_require_handshake_confirmation for ZeroRTT test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_handshake.h ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/quic_crypto_server_config.cc
diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc
index 5391673fd708ba3fc52b537cd066fea8ef5ac18d..0b42e62ebef3656c7705c1342d2e6a7d5471aaa6 100644
--- a/net/quic/crypto/quic_crypto_server_config.cc
+++ b/net/quic/crypto/quic_crypto_server_config.cc
@@ -1014,6 +1014,14 @@ void QuicCryptoServerConfig::EvaluateClientHello(
helper.ValidationComplete(QUIC_NO_ERROR, "");
return;
}
+ // If we hit this block, the server nonce was empty. If we're requiring
+ // handshake confirmation for DoS reasons and there's no server nonce present,
+ // reject the CHLO.
+ if (FLAGS_quic_require_handshake_confirmation) {
+ info->reject_reasons.push_back(SERVER_NONCE_REQUIRED_FAILURE);
+ helper.ValidationComplete(QUIC_NO_ERROR, "");
+ return;
+ }
// We want to contact strike register only if there are no errors because it
// is a RPC call and is expensive.
« no previous file with comments | « net/quic/crypto/crypto_handshake.h ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698